Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadChunk(x, y, false) returns false if a 1.12.2 < chunk has not been converted to 1.13 #1403

Closed
Blazzike opened this issue Sep 2, 2018 · 3 comments
Labels
help wanted Community assistance requested, PRs welcome. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to.

Comments

@Blazzike
Copy link

Blazzike commented Sep 2, 2018

What behaviour is expected:

true

What behaviour is observed:

false

Steps/models to reproduce:

Use loadChunk(x, y, false) on a chunk that has not been converted.

Paper build number:

206 (1.13.1)

@aikar aikar added type: bug Something doesn't work as it was intended to. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. core-team-task labels Sep 2, 2018
@aikar
Copy link
Member

aikar commented Sep 2, 2018

This will be fixed as part of the Async Chunk Loading work.

@aikar
Copy link
Member

aikar commented Sep 2, 2018

Actually this is better fixed separate, can someone PR loadChunk(int, int, boolean) to do:

return world.getChunkProviderServer().getChunkAt(x, z, true, generate || isChunkGenerated(x, z)) != null; // Paper

@aikar aikar added help wanted Community assistance requested, PRs welcome. and removed core-team-task labels Sep 2, 2018
@aikar
Copy link
Member

aikar commented Sep 3, 2018

Fixed in 208+

@aikar aikar closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community assistance requested, PRs welcome. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to.
Projects
None yet
Development

No branches or pull requests

2 participants