Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tameable#getOwnerUniqueId is incorrectly annotated as NotNull #2968

Closed
chickeneer opened this issue Feb 15, 2020 · 0 comments
Closed

Tameable#getOwnerUniqueId is incorrectly annotated as NotNull #2968

chickeneer opened this issue Feb 15, 2020 · 0 comments

Comments

@chickeneer
Copy link
Contributor

@chickeneer chickeneer commented Feb 15, 2020

https://github.com/PaperMC/Paper/blob/master/Spigot-API-Patches/0085-Tameable-getOwnerUniqueId-API.patch#L30

Looks like a @NotNull was accidentally added to this method. Should be a quick and simple switch. JavaDocs even indicate that null is a possibility. This method should be @Nullable.

Working on other things, otherwise would construct a PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.