Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for whether disabling sand duping #3724

Closed
HeartyYF opened this issue Jun 30, 2020 · 19 comments
Closed

Config for whether disabling sand duping #3724

HeartyYF opened this issue Jun 30, 2020 · 19 comments

Comments

@HeartyYF
Copy link

Thank you all for the awesome work about paper. It helped a lot about the performance.

But these days we noticed that sand duping has been fixed. I don't know why you cool guys think it's good to fix it, but just as this post says, it's a sandbox game after all, so it would be really good to add a toggle for that.

@electronicboy
Copy link
Member

There already is one, see the unsupported section... Use the search in the future.

@aikar
Copy link
Member

aikar commented Jun 30, 2020

No. The only reason we added a config for TNT duping is due to Mojang leaving it temporarily as a mechanic for automated mining.

Sand Duping will not be included as a config.

@HeartyYF
Copy link
Author

There already is one, see the unsupported section... Use the search in the future.

If I don't misunderstand, that one is about TNT dunping, not sand?

@electronicboy
Copy link
Member

I misunderstood something, ref aikars answer

@linklelinklelin
Copy link

Dear developers:
It's great to find that PaperMC is becoming more and more perfect, fixing bugs and optimizing running speed. And that’s why more and more sever is using PaperMC instead of original edition.
However, after all Minecraft is a open sandbox game, and we have to admit that that's why Minecraft is so charming - you can do anything you like in this game, and you can change the rules of the game freely as you like. We can use those "features" as we like, building sand machine, etc. Now nearly every survival mode server whose players like to build large buildings or machines in Minecraft will build a sand machine. I believe that there is no right or wrong for players to use theses "features" - that's not fair, right?
But now in PaperMC players are Restricted. That might mean that we players could only get back to original edition, bearing the awful performance and running speed. So here please: Open the config of the features.

@wrnm1h
Copy link

wrnm1h commented Jun 30, 2020

If sand-duping is completely disabled, then survival players would have no ways to get lots of sands, red sands, or gravels rather than digging them directly, which would badly destroy the landforms.
Sandstones, red sandstones, and concrete in different colors which made from sands, red sands, and gravels are one of the necessary materials for players to build large buildings, and quite a lot of survival players are used to getting those blocks by using the sand-duping feature since 1.8.
Hope you give the survival players (like us) who do not want to leave pure survival but want to vigorously develop architecture a chance to determine whether to allow this vanilla feature themselves. Sincerely : )

@A248
Copy link
Contributor

A248 commented Jun 30, 2020

High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies

@linklelinklelin
Copy link

Yeah but who can define what is inconsistency and what isn't? I think it's players that can really identify that, so if players need that, we should add that.

@A248
Copy link
Contributor

A248 commented Jun 30, 2020

Yeah but who can define what is inconsistency and what isn't? I think it's players that can really identify that, so if players need that, we should add that.

Nope, sorry. Those who collectively work on the project define what's an inconsistency.

@kickash32
Copy link
Contributor

Just use a plugin to give players sand gravel, whatever. This exploit fix is nessesary to fix because it also allows enderdragon egg duping and other wierd bugs. Alternatives to the "mechanic" exist so Paper will not be providing a config option.

@aikar
Copy link
Member

aikar commented Jun 30, 2020

not wanting to "dig it directly" is a dangerous argument to make for a mining game. What about Diamonds? Obsidian? Every other block that you can't instant farm?

We have a history in this project of fixing item duplication bugs without config options, and that is what this is too.

Sandbox games do not mean anarchy. They mean that there are no fixed paths for doing things. Yes, exploits can be seen as a "way of doing things", but there has to be a line drawn.

Creative mode exists for servers that do not care about resource management.

In the survival game mode, it is expected that you put in some effort to obtain the resources to build the buildings you want.

Typically, players go farther away from their base to not impact the aesthetics of their own base to solve that issue.

If you as a server owner are ok with a player taking something and making copies of it, you can achieve this by using plugins or even data packs, or creative mode.

Add a villager recipe that trades 1 sand for 3 sand.
Or even just 1 emerald for 20 sand if your main concern is land destruction.

A plugin command to /givesand

Here is a plugin:
https://dev.bukkit.org/projects/item-duplicator

This is a political issue in that your wanting to allow players to obtain sand without putting in the work to obtain the sand.
Many solutions exist for this even in vanilla, so there is no reason to add a config here.

But as a survival server owner myself, I extremely caution you going down this route. As a server owner, it is our job to draw that line on "ok that's too much". First they ask for Sand, then some other post processed block, then obsidian, then diamond.

If you allow one, the argument then shifts "But you allowed sand to be duped!".

The emerald for sand villager trading idea is I believe the best compromise. It makes them trade 1 set of effort for another to mass obtain sand, and I encourage you to seek that path.

@MissPotato
Copy link

I understand the concern of wanting to prevent grief of the overworld, as this is a place that people wish to build. It's a bit different to mine underground as it's not easy to see. And while I'm also an advocator for config EVERYTHING I do have some suggestions to provide sand.

Something I've been considering for my world is adding sand and clay to spawn underground like gravel does. You could also make a dimension/world that resets every so often specifically for the purpose of mining. Villager trading is also an option and is already "balanced" in terms of gains. Admin shops are also an option, you may not even need an economy, you could exchange say cobble for sand. You could also use loot-tables to make mobs drop the blocks. Or you could go with the skyblock plugin style and make it so cobble/stone generators can randomly produce a different block.

@elhertz
Copy link

elhertz commented Jul 5, 2020

The decision of not adding an option for this doesn't make sense to me. Not all of us have big servers. Some use paper to chill and have a lag-free experience with a few friends.
You're making this glitch a big deal for big servers and that's right, but what about the rest of us who just want to experiment with vanilla minecraft glitches and have a lag-free experience at the same time?
Don't get me wrong, I love paper! This decision just doesn't make sense and that's just my opinion.
Keep up the good work.
Regards.

@FAT32SHAMER
Copy link

Give server owns the ability to choose instead of choosing for us. Not everyone is looking to run a tight ship, and for the people that aren’t they can just edit the config.

Are you able to at lease provide the commit hash of where it was patched?

@carthradge4
Copy link

Agreed, not having an option like for other glitches seems like an inconsistent decision. Paper is needed for large server, but to have behavior like this completely patched without an option to reenable it is not consistent with other fixes added (TNT dupping, etc). We just want to play a Vanilla Minecraft experience without the lag.

@Machine-Maker
Copy link
Member

I believe the only reason the tnt duplication is still in paper, is because that's the only dupe that mojang has said they aren't fixing until there is some way to replace it, other wise it would be removed as well.

If you want an easy way to get sand, setup a command block to give sand to everyone.

@carthradge4
Copy link

Why is this decision being made for all paper server? Just give an option and everyone is happy.

@FranKusmiruk
Copy link

Why is this decision being made for all paper server? Just give an option and everyone is happy.

Paper is open-source, you are free to create your own fork and add that option if you really feel like your server depends on this bug. I also believe there's a fork which was specifically made to support these glitches Paper has fixed.

@aikar
Copy link
Member

aikar commented Jul 6, 2020

Paper has been fixing duplication issues for YEARS without any configs.

We're not going to start cherry picking dupes we add configs for and dupes we don't. It is not this projects goal to be 100% vanilla for bugs, or even to provide configs for all bugs.

We add configs for MECHANICS, not "give me more items" duplication.

As I said above, this is a resource dupe. This is not a mechanic. This is purely for players to not have to spend the time collecting a resource.

There is no difference in sand duping vs diamond duping vs shulker duping.
Just because your players are use to using it doesn't matter. It's still a dupe. The donkey dupes are all fixed too, and no we aren't adding configs for them either.

The only difference is some peoples opinion is "it's not that valuable, so it's ok".

If that is ok with you, as I said above, use a plugin. Use a data pack. Use command blocks with the /give command.

There are plenty of solutions for you to provide your players with free sand.

But if you really insist, fork the project, open EntityFallingBlock and remove the checks.

Paper has years of precedent here. We're not going to break our line over something as silly as this.
We only relented for TNT because it was a mechanic concept, and that it doesn't 'give you resources'.
TNT is an exception, not the rule, one that I was very adamantly against, and still really don't like having a config for it either.

If you want these dupes, then please start a fork and re-enable them, but these do not align with the Paper project.
Or, just use one of the alternative solutions I have suggested.

image

@PaperMC PaperMC locked as resolved and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests