Item drop Mythicmobs Mobs not combined item paper 1.16.4

[Chillchillnetwork]

What behaviour is expected:

• Item drop mythicmobs combine item paper

What behaviour is observed:

• Item drop Mythicmobs not combined item paper 1.16.4 By the way, making it combined is restart server , Enter the server again , load chunk but the name of the item is the same.

Steps/models to reproduce:

Boss drop in mythicmobs
https://mcpaste.io/866a167ca699e822

• Example Mythicmobs NBT items not combined : https://www.youtube.com/watch?v=OMhOFHD6wyw

Plugin list:

• AuctionHouse , BetterDrops , ChestShop , Citizens , Clearlag , CMI , Command Panels , EntityTrackerFixer , ItemEdit , Jobs , LockettePro , LuckPerms , MobFarmManager , MythicMobs-4.11.0 , PlaceholderAPI , ProtocolLib , Shopkeepers-2.12.0

Paper version:

• paper-1.16.4-324 [Lastest Version Paper] Confirm!

[electronicboy]

We'd need to see the NBT data from those items as they're likely not the same, this is likely down to the spigot issue with modern servers where the data does not always match up properly due to technical reasons

[Machine-Maker]

#4886?

[Chillchillnetwork]

@Machine-Maker Yes I confirm paper 1.16.4 dev 324

[Chillchillnetwork]

I tried updating paper and it was the same.

[aikar]

Should be same issue I just fixed here: starlis/empirecraft@1476d69

I will try to get this into Paper here soon, but gonna see if i can improve it to just change equals on the component modifiers checks instead, though I think legacy is still safer as it can deal with dummy blank wrapper components too.

[Charoxy]

I wait this

[hkkongou]

actually there are many people waiting for this paper update...
hopefully this issue can be fixed and closed asap

[electronicboy]

Spigot may have actually done some changes which negates the need for that change, we'll see, I guess

[tytyrocks12]

This issue still persists with mythicmobs. Has been causing tons of extra moderation to keep the trades going with the players, as 50% of all items do not match anymore.

[tytyrocks12]

I tested this on the latest version of Paper, Paper-406

[hkkongou]

did paper fixed this problem in latest patch?

[badnameok]

just tested on 1.16.5, it doesn't seem to be fixed yet. NBT tags shown in picture. 1st Item: Directly dropped 2nd Item: After relogging.

[aurorasmiles]

Don't spam and randomly tag people.

[electronicboy]

Because to fix a problem, we need to be able to reproduce it and look deeper into it, given that this also highly falls into craftbukkits flawed handling of components, stuff like this is generally a pain in the ass to resolve without breaking other things

We don't support premium/closed source plugins, especially as they make it much harder to even bother to begin, and I have personally asked on multiple occasions for people to provide a minimal reproduction case.

If somebody wants to produce a jar with aikars fix, that might be worth testing, I'd build it myself but am not feeling well right now

[badnameok]

here is a config and steps for reproduction. just in case it helps

1. put this into a .yml file in /MythicMobs/Items

material_common_zombie_flesh:
  Id: ROTTEN_FLESH
  Display: "&cZombie Flesh"
  Lore:
  - "&7Common Material"

2. restart server or /mm r
3. /mm i get material_common_zombie_flesh
4. disconnect and reconnect to the server
5. repeat step 3. The two items shouldn't stack and will have the same NBT as shown above.

[electronicboy]

We already have spigots fixes, if something else is interfering, we'd need more info on reproducing as this specifically looks like an issue with spigots chat API mangling stuff

reproduction in MM is generally useless given the whole premium/locked down nature of the plugin, it's not viable for us to go deep into debugging it

[aikar]

There is a possibility it's paper specific to making the issue worse, as we have some changes to the format that spigot doesn't that's at play here causing the issue.

But i believe spigot had issues for any old item pre 1.16 comparing to 1.16 too. It's overall a mess...

[Proximyst]

If someone has any actual information to add, please do ping us on Discord or IRC.
The issue will be solved eventually. Asking over and over will not magically resolve it.

[electronicboy]

https://paste.gg/p/anonymous/76e0ff5952bd4c35a64c35230097cccd

Looks like the typical joyous conversions that CB does where they're wrapped, did spigot change this or something? I recall this being a constant issue after a vanilla update where vanilla changed the way components worked and basically broke all hell loose

[electronicboy]

https://github.com/PaperMC/Paper/blob/master/Spigot-Server-Patches/0522-Update-itemstack-legacy-name-and-lore.patch
The itemstacks that MM is creating are in fact invalid, however, this only seems to be caught later on, looks like this needs applying to bukkit stacks too; Need to work out if this is an API issue or a plugin issue