Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate NamespacedKey(String, String) constructor or add new static factory method #7753

Closed
jpenilla opened this issue Apr 19, 2022 · 0 comments · Fixed by #7760
Closed
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.

Comments

@jpenilla
Copy link
Member

jpenilla commented Apr 19, 2022

Is your feature request related to a problem?

It's not always the case that an NSK will be owned by a plugin, for example with things added by datapacks. Currently you would need to use fromString and concatenate the key and value with : to avoid deprecated methods.

Describe the solution you'd like.

Undeprecate the constructor or add a new static factory method

Describe alternatives you've considered.

Using the deprecated method or fromString

Other

The javadoc should mention what the proper use case is and refer to the other factory methods/constructors for their purposes.

@jpenilla jpenilla added type: feature Request for a new Feature. status: needs triage status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant