Fix: Serialize jobenv to envVars PS-15020 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperspace-philip
changed the title
added 2 commits
September 22, 2020 01:38
|
This seems to fix #322 |
|
This worked for me! running same code from #322, where previously didn't |
added 4 commits
September 23, 2020 15:15
This reverts commit e23fd65.
worksewell
reviewed
Sep 24, 2020
gradient/cli/jobs.py
Outdated
| help="Environmental variables ", | ||
| help="Environmental variables (deprecated)", | ||
| cls=common.GradientOption, | ||
| ), |
There was a problem hiding this comment.
nit: I'd probably just remove this. If you want to support the old flag you can just add it to the --envVars option.
worksewell
reviewed
Sep 24, 2020
worksewell
reviewed
Sep 24, 2020
worksewell
approved these changes
Sep 24, 2020
added 2 commits
September 25, 2020 08:38
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serialization of job environment
Test Plan:
Create a job and specify jobEnv parameter. Use command "env" to see if job environment is affected