New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR2-22 CR2-49 CR2-48 add metrics list to sdk #328
Conversation
CR-22 View custom metrics from CLI
|
…xperiments and deployments
This reverts commit dc9a1b9.
this can be ready for review, i made a separate PR for messing around with tests #331 |
Co-authored-by: Colin <colin.t.welch@gmail.com>
"interval": interval, | ||
"objecttype": self.OBJECT_TYPE, | ||
"handle": instance_id, | ||
"metrics_api_url": "% s:8080"% metrics_api_url if 'local' in metrics_api_url else metrics_api_url, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be too broad of a check. How about localhost
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at first i assumed it would contain localhost
but when i logged out metrics_api_url
it said something along the lines of http...local.paperspace...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i could check local.paperspace
instead duh lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is specific to that domain then maybe we should be including the port in the metrics URL returned for workloads in that domain, ie. in the service layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea that would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list
exists. Deployments, experiments, jobs, notebooks all currently return null
LGTM
🎉 This PR is included in version 1.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adding list custom metrics functionality to sdk and cli for jobs, experiments, deployments, and notebooks
QA Test Plan:
list
command shows up in the help text:gradient deployments metrics --help
list
command:gradient deployments metrics list --id XYZ
, should return custom metrics (a list of words),null
but that's okay for now, just checking that this new command is available. note the stuff that returnsnull
below if any and I'll solve that in a separate ticket.