fix(notebooks): remove --name from gradient notebooks start command
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested against psdev, created a notebook in the UI, stopped it, ran ```bash python3 -m gradient notebooks start \ --clusterId <cluster ID> \ --machineType psdev-worker --notebookId <notebook ID> ``` and saw the notebook successfully restart. Verified that `--name` was no longer a valid CLI param for the command with ```bash python3 -m gradient notebooks start --help ```
bbatha
approved these changes
Sep 3, 2021
e-r-i-k-a
approved these changes
Sep 3, 2021
cwetherill-ps
deleted the
cwetherill/pla-407-remove---name-from-gradient-notebooks
branch
|
🎉 This PR is included in version 1.7.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against psdev, created a notebook in the UI, stopped it, ran
and saw the notebook successfully restart. Verified that
--namewas nolonger a valid CLI param for the command with