Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): fix datasets files put command #363

Merged
merged 3 commits into from Sep 9, 2021
Merged

Conversation

lamroger
Copy link
Contributor

@lamroger lamroger commented Sep 9, 2021

Overview:
The command was getting a presigned url without providing file name and would get 403'd

Test plan:

  1. Create a dataset version: gradient datasets versions create --id <dataset id>
  2. Start various ways of putting files
gradient datasets files put --id <dataset ref from above> --source-path file.txt
gradient datasets files put --id <dataset ref from above> --source-path workflow.yaml --target-path helloworld/
gradient datasets files put --id <dataset ref from above> --source-path workflow.yaml --target-path helloworld/yoloswag
gradient datasets files put --id <dataset ref from above> --source-path random/test/

putting a file, putting a folder, putting a file in a target path
3. Commit the dataset python gradient datasets versions commit --id <dataset ref from above>
4. Verify in CLI or UI that files are where they are expected to be

@lamroger lamroger merged commit 88464c1 into master Sep 9, 2021
@lamroger lamroger deleted the roger/dataset-put branch September 9, 2021 20:39
@PSBOT
Copy link

PSBOT commented Sep 9, 2021

🎉 This PR is included in version 1.7.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants