Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clusters): machineTypes list returns no data PLA-867 #386

Merged
merged 3 commits into from Apr 13, 2022

Conversation

bbatha
Copy link
Contributor

@bbatha bbatha commented Apr 13, 2022

Fixed to:

  • Include public cluster data by default. You cannot use --clusterId
    to see public cluster data because of the way the endpoint works.
  • When there are inactive vmTypes in the cluster the response does not
    include enough info to render the table properly so inactive instances
    are now filtered from the response.

@bbatha bbatha force-pushed the bbatha/pla-887-gradient-clusters-machinetypes-list branch from 9f52dfd to 510f306 Compare April 13, 2022 15:37
* Include public cluster data by default. You cannot use --clusterId
to see public cluster data because of the way the endpoint works.

* When there are inactive vmTypes in the cluster the response does not
include enough info to render the table properly so inactive instances
are now filtered from the response.
@bbatha bbatha force-pushed the bbatha/pla-887-gradient-clusters-machinetypes-list branch from 510f306 to 8e37a76 Compare April 13, 2022 15:38
Copy link
Contributor

@cwetherill-ps cwetherill-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbatha bbatha merged commit 2769721 into master Apr 13, 2022
@bbatha bbatha deleted the bbatha/pla-887-gradient-clusters-machinetypes-list branch April 13, 2022 16:18
@PSBOT
Copy link

PSBOT commented Apr 13, 2022

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants