Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Height for Card component #6

Closed
FrancoMuniz opened this issue Feb 15, 2020 · 2 comments
Closed

Dynamic Height for Card component #6

FrancoMuniz opened this issue Feb 15, 2020 · 2 comments
Assignees
@WrathChaos
Labels
enhancement New feature or request

Comments

@FrancoMuniz
Copy link

FrancoMuniz commented Feb 15, 2020 •
edited
Loading

I'd really appreciate dynamic height being implemented on the Card component!

It's implemented on the "SimpleCard" but not in the "Card" one.
The idea is basically adjusting the height of the card depending on the size of the content inside.

Thanks!
@WrathChaos
Copy link
Contributor

Hey again Franco,
Really sorry it's been a tough week. I will make it ASAP :)

@WrathChaos WrathChaos self-assigned this Feb 18, 2020
@WrathChaos WrathChaos added the enhancement New feature or request label Feb 18, 2020
@WrathChaos
Copy link
Contributor

Hey again @FrancoMuniz,
I've done the dynamic height for the Card one :) If you do not want the dynamic height you can use the new prop: textContainerNumberOfLines :) Thank you for the enhancement request. Waiting for more.

Please check it out:

Release: 0.3.0 🎊🎉🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WrathChaos WrathChaos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WrathChaos @FrancoMuniz