Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Support React 17 #151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support React 17 #151

wants to merge 4 commits into from

Conversation

prageeth
Copy link

@prageeth prageeth commented Jan 23, 2021

This PR fixes #149 and ensures:

  • that we can use React 17 as a peer dependency
  • fixes some npm vulnerabilities using npm audit fix

@benprofitt
Copy link

Please release this fix, I love this package and I also love using the most recent version of react 😁
Super useful package, keep up the great work 👍

@prageeth
Copy link
Author

@Paratron any chance this can be merged?

@fstn
Copy link

fstn commented Feb 3, 2021

Need that to ... PLease merge it

@prageeth
Copy link
Author

prageeth commented Feb 6, 2021

@benprofitt @fstn or anyone still stuck with this issue, you can use my branch directly from the git repo in the mean time. I use this in my own projets:

npm install hookrouter@pureartisan/hookrouter#master --save

@alvaradojl
Copy link

Please merge this so we can start using react 17! :)

@fstn
Copy link

fstn commented Mar 20, 2021 via email

@alvaradojl
Copy link

@benprofitt @fstn or anyone still stuck with this issue, you can use my branch directly from the git repo in the mean time. I use this in my own projets:

npm install hookrouter@pureartisan/hookrouter#master --save

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

@prageeth
Copy link
Author

prageeth commented Mar 20, 2021

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

@alvaradojl It's possible that your global node cache still uses the old package.

Anyhow, I've just gone ahead and published a "patched" version with a few other fixes (open PRs).

npm i @patched/hookrouter@1.3.1

Let me know if you have any issues. You can also view the exact changes that are included here:
master...pureartisan:patched

NOTE: Your imports will ofcourse have to use @patched/hookrouter as the package name.

import { navgiate } from '@patched/hookrouter';

@mkayander
Copy link

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

@alvaradojl It's possible that your global node cache still uses the old package.

Anyhow, I've just gone ahead and published a "patched" version with a few other fixes (open PRs).

npm i @patched/hookrouter@1.3.1

Let me know if you have any issues. You can also view the exact changes that are included here:
master...pureartisan:patched

NOTE: Your imports will ofcourse have to use @patched/hookrouter as the package name.

import { navgiate } from '@patched/hookrouter';

@prageeth Thanks for the patch, managed to get it working on React 17. The only problem i got was it missing the TS declarations. I copied them from the main version to a separate .d.ts file in my project, and it seems to work alright like this.

@ohchad
Copy link

ohchad commented May 29, 2021

I really liked this approach while it worked, but I can not have all these hacks in a production build and so, I'll be removing it from my project... wasted a lot of hours btw before finding this thread. You should merge your fix @prageeth and stop updating this thread.

@v33y
Copy link

v33y commented Jul 20, 2021

I mean at this point @prageeth you should merge. @Patatron last update was 8 months ago

@prageeth
Copy link
Author

Unfortunately I don’t have permissions to merge any PRs in this repo. Therefore, I’m using my own @patched/hookrouter package. I’ve recently published a few more fixes there. So if anyone wants to continue, please feel free to use it.

v33y and others added 3 commits September 14, 2022 13:01
* now has types support

* json update

Co-authored-by: Victor Kuria <victorkushmere@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 17
7 participants