Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added release notes #100

Merged
merged 5 commits into from Mar 17, 2017
Merged

added release notes #100

merged 5 commits into from Mar 17, 2017

Conversation

joeyrivera
Copy link
Contributor

No description provided.


### Visitor Activities

A few updates where made to the `query` endpoint for both version 3 and 4. These include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were instead of where

@juan-nunez
Copy link
Contributor

👍

@@ -0,0 +1,29 @@
# Release Notes

Here you'll find the latest updates on what's changed in the Pardot API and API documentation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title contains several contractions and slang. Best to avoid such in tech writing.
Perhaps "This page contains the release notes for the Pardot API and related documentation."


### Visitor Activities

A few updates were made to the `query` endpoint for both version 3 and 4. These include:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for flourishing with superfluous 'a few updates' or 'these include. EX:

'query' end-point (v3-4):

  • blah
  • blah

also, use end-point or end point (Endpoint is a specific name for several companies, band names, etc.)


A few updates were made to the `query` endpoint for both version 3 and 4. These include:

* any email activity that is part of an email list will now include the list_email_id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'related to' instead of 'is a part of'

A few updates were made to the `query` endpoint for both version 3 and 4. These include:

* any email activity that is part of an email list will now include the list_email_id
* any email activity that belongs to an email which used an email template, will include the email_template_id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'related to' instead of 'belongs to'
'generated from' instead of 'which used'

docs/index.md Outdated
@@ -77,6 +78,7 @@ The Pardot API supports several output formats, each of which returns different
* `full` -- Returns all supported data for the Pardot object and all objects associated with it.
* `simple` -- Returns all supported data for the data for the Pardot object.
* `mobile` -- Returns an abbreviated version of the object data. This output format is ideal for mobile applications.
* `bulk` -- Returns basic data for an object without a total object count. Used for querying [large amounts of data](kb/bulk-data-pull/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using parenthesis '(does not provide total object count)'.

docs/index.md Outdated
@@ -5,6 +5,7 @@ Welcome! All up-to-date documentation of Pardot's official API is housed here. A
* If you have a question about the API, feel free to [open a ticket](https://pardot.desk.com/) with our Support team.
* To report an inconsistency in the documentation, please [open an issue on GitHub](https://github.com/Pardot/api-docs/issues). [Pull requests](https://github.com/Pardot/api-docs/pulls) are welcome as well!
* If you've written your own library or wrapper for Pardot's API, submit a [pull request](https://github.com/Pardot/api-docs/pulls) updating the `index.md` file with a link to your repository, and we'll be glad to consider linking it up.
* If you want to see what's changed recently in the API or the documentation, please go visit the [Release Notes](kb/release-notes).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several slang phrases here. Suggest:
For the latest information on updates to the API and related documentation, refer to the [Release Notes]


* any email activity that is part of an email list will now include the list_email_id
* any email activity that belongs to an email which used an email template, will include the email_template_id
* new filters are available to query visitor activities by [object type](api-version-4/visitor-activities/#supported-search-criteria):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[filter visitor activities by various object types]


#### Email

* when using the `read` endpoint, you can now remove the email text and html body message from the response by setting [include_message](api-version-4/emails/#supported-parameters) to false.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end-point (not endpoint)
HTML (not html)
'you can exclude' instead of 'you can now remove'


#### Other

In the documents under the "Manipulating the Result Set" section for many of the objects, it was identified the `sort_by`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentions of default value: 'id' for the 'sort_by' query parameter have been removed from API documentation for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's still worth mentioning what the issue was or at least make sure to let the user know to set this. Thoughts?

@joeyrivera joeyrivera merged commit fd55138 into master Mar 17, 2017
@franciscosanchezsfdc franciscosanchezsfdc deleted the jr/W-3756786 branch June 11, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants