-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Create a new heap variant to replace Arc<str> #30
Conversation
Thanks for the feedback @NobodyXu! I did look at |
Is that for the copy-on-write usage? Well then, I think this does require creation of another unique But then, that can be postponed until this feature is completed in This is quite a novel way to implement Thanks for taking your time to answer my question! |
This PR changes our
HeapString
implementation from using anArc<str>
to a custom definedArcString
type. This type is more analogous toArc<[u8]>
, specifically it allocates a buffer which may be larger than the "string" it contains. This gets us closer to being a true drop-in replacement forString
and allows us to write APIs for mutating aCompactStr