-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PFFileDataStream for streaming file Downloads. #241
Conversation
a6706cc
to
8e5f379
Compare
|
||
/*! | ||
@abstract Why? Because Nikita. | ||
@discussion Actually, this does have some practical use. When downloading a file stream via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember precisely, but I think these annotations are simply ignored for class documentation.
Looks great, minus nits. The only question about this that I have - what is the expected behavior for using this stream with |
According to this mailing list it would appear that you should still call Seeing as apple has never used this themselves and probably never will due to the API confusion surrounding it, I think it's safe enough to ignore this for now. |
Sounds great! Fix nits and let's ship! |
8e5f379
to
218d074
Compare
Please rename before shipping. As much as I love the name (it has my name in it :D), not sure if other people will understand this. |
This is an NSInputStream proxy that is used for file downloads while concurrently reading and writing to a file. This allows us to truly stream from parse using `-[PFFile getDataDownloadStreamInBackground]`, whereas before it had the potential to break if you consumed it too fast.
218d074
to
9fac0f8
Compare
…nusonebyte Added PFFileDataStream for streaming file Downloads.
This is an NSInputStream proxy that is used for file downloads while concurrently reading and writing to a file. This allows us to truly stream from parse using
-[PFFile getDataDownloadStreamInBackground]
, whereas before it had the potential to break if you consumed it too fast.