Skip to content

Commit

Permalink
feat: remove Node 12 support (#2277)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This version removes support for Node 12; the new minimum required Node version is 14.
  • Loading branch information
damianstasik committed Sep 27, 2022
1 parent 272134d commit 18b0e76
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ jobs:
strategy:
matrix:
include:
- name: Node 12
NODE_VERSION: 12.22.12
- name: Node 14
NODE_VERSION: 14.20.0
- name: Node 16
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![Build Status](https://github.com/parse-community/parse-dashboard/workflows/ci/badge.svg?branch=alpha)](https://github.com/parse-community/parse-dashboard/actions?query=workflow%3Aci+branch%3Aalpha)
[![Snyk Badge](https://snyk.io/test/github/parse-community/parse-dashboard/badge.svg)](https://snyk.io/test/github/parse-community/parse-dashboard)

[![Node Version](https://img.shields.io/badge/nodejs-12,_14,_16,_18-green.svg?logo=node.js&style=flat)](https://nodejs.org/)
[![Node Version](https://img.shields.io/badge/nodejs-14,_16,_18-green.svg?logo=node.js&style=flat)](https://nodejs.org/)
[![auto-release](https://img.shields.io/badge/%F0%9F%9A%80-auto--release-9e34eb.svg)](https://github.com/parse-community/parse-dashboard/releases)

[![npm latest version](https://img.shields.io/npm/v/parse-dashboard/latest.svg)](https://www.npmjs.com/package/parse-dashboard)
Expand Down Expand Up @@ -102,7 +102,6 @@ Parse Dashboard is continuously tested with the most recent releases of Node.js

| Version | Latest Version | End-of-Life | Compatible |
|------------|----------------|-------------|--------------|
| Node.js 12 | 12.22.12 | April 2022 | ✅ Yes |
| Node.js 14 | 14.20.0 | April 2023 | ✅ Yes |
| Node.js 16 | 16.17.0 | April 2024 | ✅ Yes |
| Node.js 18 | 18.9.0 | May 2025 | ✅ Yes |
Expand Down
3 changes: 1 addition & 2 deletions ci/ciCheck.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ async function checkNodeVersions() {
releasedVersions,
latestComponent: CiVersionCheck.versionComponents.minor,
ignoreReleasedVersions: [
'<12.0.0', // These versions have reached their end-of-life support date
'>=13.0.0 <14.0.0', // These versions have reached their end-of-life support date
'<14.0.0', // These versions have reached their end-of-life support date
'>=15.0.0 <16.0.0', // These versions have reached their end-of-life support date
'>=17.0.0 <18.0.0', // These versions have reached their end-of-life support date
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"parse-dashboard": "./bin/parse-dashboard"
},
"engines": {
"node": ">=12.22.0"
"node": ">=14.0.0"
},
"main": "Parse-Dashboard/app.js",
"jest": {
Expand Down
1 change: 0 additions & 1 deletion src/lib/tests/e2e/dashboard.e2e.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ function startParseDashboardAndGetOutput(args) {
return new Promise((resolve) => {
const indexFilePath = path.resolve('./Parse-Dashboard/index.js');
const child = spawn('node', [indexFilePath, ...args], { cwd: '.', timeout: timeoutInMs });
setTimeout(() => { child.kill(); }, timeoutInMs); // node.js 12 hack (spawn timeout option is not supported.)

let output = '';
child.on('error', () => { resolve(output); });
Expand Down

0 comments on commit 18b0e76

Please sign in to comment.