feat: keep entered filter value when changing filter operator (#2313)

parse-community · Oct 9, 2022 · d6d38bf · d6d38bf
1 parent 8e60931
commit d6d38bf
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/components/Filter/Filter.react.js b/src/components/Filter/Filter.react.js
@@ -13,10 +13,16 @@ import stringCompare  from 'lib/stringCompare';
 import { CurrentApp } from 'context/currentApp';
 
 function changeField(schema, filters, index, newField) {
-  let newFilter = new Map({
+  const allowedConstraints = Filters.FieldConstraints[schema[newField].type];
+  const current = filters.get(index);
+  const constraint = current.get('constraint');
+  const compare = current.get('compareTo');
+  const defaultCompare = Filters.DefaultComparisons[schema[newField].type];
+  const useExisting = allowedConstraints.includes(constraint);
+  const newFilter = new Map({
     field: newField,
-    constraint: Filters.FieldConstraints[schema[newField].type][0],
-    compareTo: Filters.DefaultComparisons[schema[newField].type]
+    constraint: useExisting ? constraint : Filters.FieldConstraints[schema[newField].type][0],
+    compareTo: (useExisting && typeof defaultCompare === typeof compare) ? compare : defaultCompare
   });
   return filters.set(index, newFilter);
 }