fix: always pass boolean value when toggling checkbox #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
|
Is this ready for review? |
|
@mtrezza yes 👍 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 20, 2021
# [3.3.0-alpha.6](3.3.0-alpha.5...3.3.0-alpha.6) (2021-10-20) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
|
🎉 This pull request has been released in version 3.3.0-alpha.6 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 1, 2021
# [3.3.0-beta.1](3.2.1-beta.1...3.3.0-beta.1) (2021-11-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
|
🎉 This change has been released in version 3.3.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 1, 2022
# [3.3.0](3.2.1...3.3.0) (2022-01-01) ### Bug Fixes * always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59)) * app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6)) * bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021)) * context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35)) * link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d)) * manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b)) * notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6)) * upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14)) * upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e)) * upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335)) * upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0)) * upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0)) ### Features * add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1)) * add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786)) * add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e)) * allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73)) * allow graphQL headers ([34536b3](34536b3)) ### Reverts * Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
|
🎉 This change has been released in version 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This PR gets rid of the error message about the checkbox in the
DataBrowserHeaderBarbeing both controlled and uncontrolled:Related issue: #1872
Approach
The cause of the issue is the value type passed to the
selectedprop of theDataBrowserHeaderBarcomponent as sometimes it wasnullinstead of a boolean.TODOs before merging