Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Node 12 support #2277

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Sep 25, 2022

New Pull Request Checklist

Issue Description

This PR removes Node.js 12 support.

Related issue: #2190

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 25, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik changed the title chore: remove Node 12 support completely ci: remove Node 12 support completely Sep 25, 2022
@mtrezza
Copy link
Member

mtrezza commented Sep 26, 2022

Not sure we can merge this before end of the year, since Parse Server still supports Node 12, therefore dashboard should probably too. We'll remove Node 12 support in Parse Server on Jan 1st.

Which PRs are blocked because of Node 12 support?

@damianstasik
Copy link
Contributor Author

@mtrezza #1954 is blocked due to change in React Router minimum Node version to 14.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this; this needs to be merged as a breaking change.

Parse Server is the principal package, so as a rule we should keep Parse Dashboard aligned regarding its Node version requirements. However, it's great to see that you found some time to work on modernizing Parse Dashboard and pick up the other PRs. I wound't want to see your efforts being blocked by this PR - and in 3 months Parse Server will drop Node 12 support anyway.

@mtrezza mtrezza changed the title ci: remove Node 12 support completely feat: remove Node 12 support Sep 27, 2022
@mtrezza mtrezza merged commit 18b0e76 into parse-community:alpha Sep 27, 2022
parseplatformorg pushed a commit that referenced this pull request Sep 27, 2022
# [5.0.0-alpha.1](4.2.0-alpha.17...5.0.0-alpha.1) (2022-09-27)

### Features

* remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76))

### BREAKING CHANGES

* This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 27, 2022
@mtrezza mtrezza mentioned this pull request Sep 27, 2022
3 tasks
@mtrezza mtrezza linked an issue Sep 27, 2022 that may be closed by this pull request
3 tasks
parseplatformorg pushed a commit that referenced this pull request Oct 17, 2022
# [5.0.0-beta.1](4.2.0...5.0.0-beta.1) (2022-10-17)

### Bug Fixes

* increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b))
* minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b))
* raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98))
* using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957))

### Features

* improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff))
* keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf))
* remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76))

### BREAKING CHANGES

* This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 1, 2022
# [5.0.0](4.2.0...5.0.0) (2022-11-01)

### Bug Fixes

* increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b))
* minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b))
* raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98))
* using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957))

### Features

* improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff))
* keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf))
* remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76))

### BREAKING CHANGES

* This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Node 12 support
3 participants