Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Text selection not visible in modal dialog header #2340

Merged
merged 3 commits into from
Nov 5, 2022
Merged

fix: Text selection not visible in modal dialog header #2340

merged 3 commits into from
Nov 5, 2022

Conversation

jadsonlourenco
Copy link
Contributor

@jadsonlourenco jadsonlourenco commented Nov 4, 2022 •
edited by mtrezza

New Pull Request Checklist

Issue Description

Related issue: #1831
Closes #1831

Screen Shot 2022-11-04 at 11 12 38

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 4, 2022 •
edited

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@jadsonlourenco jadsonlourenco changed the title * feat: better UX for selected text modal header feat: better UX for selected text modal header Nov 4, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: better UX for selected text modal header feat: Better UX for selected text modal header Nov 4, 2022
@mtrezza mtrezza changed the title feat: Better UX for selected text modal header fix: text selection not visible in modal dialog header Nov 5, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: text selection not visible in modal dialog header fix: Text selection not visible in modal dialog header Nov 5, 2022
@mtrezza
Copy link
Member

mtrezza commented Nov 5, 2022 •
edited

You suggested:

The fix is just to not set, or remove, this CSS:

::selection {
color: white;
background: #169cee;
}

Did you try to remove the selection color and let the browser handle this? I would expect a browser to choose a color automatically that makes the selection distinct enough.

@jadsonlourenco
Copy link
Contributor Author

Yes, I think this is the solution to this issue. Works correctly in my tests on Chrome, Safari and Firefox.

So sorry about the multiple commits, I forgot to remove the commented code.

@mtrezza
Copy link
Member

mtrezza commented Nov 5, 2022 •
edited

Perfect, thanks for your PR!

@mtrezza mtrezza merged commit fb0e79c into parse-community:alpha Nov 5, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 5, 2022
@semantic-release-bot
chore(release): 5.1.0-alpha.1 [skip ci]
9a3804e 
# [5.1.0-alpha.1](5.0.0...5.1.0-alpha.1) (2022-11-05)

### Bug Fixes

* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* remove limitation to refresh Cloud Jobs list only after 30 seconds ([#2332](#2332)) ([ad1132f](ad1132f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 5, 2022
parseplatformorg pushed a commit that referenced this pull request Mar 1, 2023
@semantic-release-bot
chore(release): 5.1.0-beta.2 [skip ci]
b0ec6a0 
# [5.1.0-beta.2](5.1.0-beta.1...5.1.0-beta.2) (2023-03-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
4b9e7ee 
# [5.1.0](5.0.0...5.1.0) (2023-05-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
* remove limitation to refresh Cloud Jobs list only after 30 seconds ([#2332](#2332)) ([ad1132f](ad1132f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make selected text visible on the Edit modal title
3 participants
@jadsonlourenco @mtrezza @parseplatformorg