Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification for Python Topology #126

Merged
merged 71 commits into from
Apr 24, 2015
Merged

Conversation

omus
Copy link
Contributor

@omus omus commented Apr 15, 2015

It is quite possible I missed something with the verification code as I am new to Storm. Let me know if I did and I'll be happy to correct any issues.

Tim Hopper and others added 30 commits August 7, 2014 16:09
Shuffling might speed things up if last used port is still open
… specific.

Raising "Exception" is bad form, so we raise RuntimeError when there's nothing
more specific, and IOError/OSError when appropriate
@omus
Copy link
Contributor Author

omus commented Apr 17, 2015

I also am in favor of using the Spec class over Component.spec.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3d2ef2f on feature/dsl_verify into * on feature/dsl*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling aae8adf on feature/dsl_verify into * on feature/dsl*.

@dan-blanchard
Copy link
Member

I got rid of Component.spec, refactored things slightly (to move all of the DSL-related stuff into the dsl package), and merged in master. I'm going to merge this into master now, since it looks good to go.

Thanks for your excellent contribution!

dan-blanchard added a commit that referenced this pull request Apr 24, 2015
Verification for Python Topology
@dan-blanchard dan-blanchard merged commit e888e57 into feature/dsl Apr 24, 2015
@dan-blanchard dan-blanchard deleted the feature/dsl_verify branch April 24, 2015 14:39
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 42ec2c3 on feature/dsl_verify into * on feature/dsl*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants