Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential integration into pycolmap #2

Open
B1ueber2y opened this issue May 2, 2024 · 1 comment
Open

Potential integration into pycolmap #2

B1ueber2y opened this issue May 2, 2024 · 1 comment

Comments

@B1ueber2y
Copy link

B1ueber2y commented May 2, 2024

Hey,

Thanks for the great work! Just want to say hi and let you know that we have just made it possible for running COLMAP BA with pycolmap and pyceres (colmap/colmap#2509), which can potentially open the door for building the optimization with pytorch as well. Might be interesting to substitute https://github.com/colmap/colmap/blob/main/pycolmap/custom_bundle_adjustment.py#L193-L205 and the PyBundleAdjuster (https://github.com/colmap/colmap/blob/main/pycolmap/custom_bundle_adjustment.py#L13) with pytorch to more easily integrate learning-based losses if we could make the optimizer achieve similar performance as in ceres : )

Best,
Shaohui

@Parskatt
Copy link
Owner

Parskatt commented May 2, 2024

Hi, that's great news! My framework is mostly just educational (and trying to keep it as not too many lines), so I don't expect it to outperform proper bundle, but definitely something I'll check out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants