Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of WQ categories #1351

Closed
annawoodard opened this issue Oct 11, 2019 · 4 comments
Closed

Take advantage of WQ categories #1351

annawoodard opened this issue Oct 11, 2019 · 4 comments

Comments

@annawoodard
Copy link
Collaborator

@tjdasso has done some great work tackling #1324. As soon as core/mem/disk specification is merged (the core specification is already implemented in his branch), we will have the ability to tell WQ specific resource requirements for a task. A next step that I think would be extremely useful would be to implement the missing pieces in order to make WQ aware of what category the task is in (as a first pass, we can try just using the app name as a category). This will allow us to take advantage of WQ's ability to optimally size tasks, using the specified resource requirements as a first guess.

For another project I'm implementing some bioinformatics pipelines, so I would be an enthusiastic tester for this use case.

@annawoodard
Copy link
Collaborator Author

cc @dthain, @btovar, @tjdasso

@dthain
Copy link
Contributor

dthain commented May 4, 2020

@trshaffer please comment here on the task category capability in the latest WQ executor.

@tshaffe1
Copy link
Contributor

I have a PR in (#1677) that does exactly what @annawoodard proposes. I added two options: one to automatically assign a fresh category for each function, and one to turn on WQ's automatic resource labeling. With both of these turned on, WQ should be able to do a pretty OK job of figuring out resource requirements automatically and subdividing large workers.

@tshaffe1
Copy link
Contributor

Now that #1677 is merged, this should be resolved

@yadudoc yadudoc closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants