Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomCheck results are sent to transports that are not configured #402

Closed
kentdr opened this issue Mar 7, 2024 · 1 comment · Fixed by #400
Closed

CustomCheck results are sent to transports that are not configured #402

kentdr opened this issue Mar 7, 2024 · 1 comment · Fixed by #400
Labels
Bug Something isn't working
Milestone

Comments

@kentdr
Copy link
Member

kentdr commented Mar 7, 2024

Describe the bug

Description

The messaging bridge attempts to send CustomCheck results to transports that are not configured for custom checks causing an error to be logged.

Expected behavior

The messaging bridge only sends CustomCheck results to transports that are configured for custom checks.

Actual behavior

The messaging bridge attempts to send CustomCheck results to transports that do not have CustomChecks configured, resulting in an ArgumentException due to a null ServiceControl queue name.

Versions

2.2.0

Steps to reproduce

  1. Write a custom check that will be executed when the messaging bridge starts
  2. Configure one transport using ReportCustomChecksTo
  3. Configure another transport without calling ReportCustomChecksTo
  4. Start the bridge, and note the errors being logged when the custom check runs.

Relevant log output

fail: NServiceBus.TimerBasedPeriodicCheck[0] Custom check failed but can be retried. System.ArgumentNullException: Value cannot be null. (Parameter 'destination')

Additional Information

Workarounds

Possible solutions

Additional information

2.2.1 Release notes

@kentdr
Copy link
Member Author

kentdr commented Mar 7, 2024

This bug has been fixed and was released with 2.2.1.

@kentdr kentdr closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
1 participant