Cant Send in 4.2 and Return in 3.x

[SimonCropp]

When a 3.X endpoint does a Bus.Return that targets a 4.2.0 endpoint the v4 endpoint can't process the message. This makes it wire incompatible.

repro https://github.com/Particular/BugsRepro/tree/master/1943MissingCompletionMessage

So in a 4.2 endpoint

Bus.Send("Returner", new Message())
  .Register<int>(i => Debug.WriteLine(i));

and in a 3.3.8 endpoint

    public void Handle(Message message)
    {
        Bus.Return(5);
    }

results in

System.TypeLoadException occurred
  HResult=-2146233054
  Message=Could not determine type for node: 'CompletionMessage'.
  Source=NServiceBus.Core
  TypeName=""
  StackTrace:
       at NServiceBus.Serializers.XML.XmlMessageSerializer.InferNodeType(XmlNode node, Object parent) in :line 0
  InnerException: 

which then bubbles

System.Runtime.Serialization.SerializationException occurred
  HResult=-2146233076
  Message=An error occurred while attempting to extract logical messages from transport message NServiceBus.TransportMessage
  Source=NServiceBus.Core
  StackTrace:
       at NServiceBus.Pipeline.Behaviors.ExtractLogicalMessagesBehavior.Invoke(BehaviorContext context, Action next) in :line 0
  InnerException: System.TypeLoadException
       HResult=-2146233054
       Message=Could not determine type for node: 'CompletionMessage'.
       Source=NServiceBus.Core
       TypeName=""
       StackTrace:
            at NServiceBus.Serializers.XML.XmlMessageSerializer.InferNodeType(XmlNode node, Object parent) in :line 0
            at NServiceBus.Serializers.XML.XmlMessageSerializer.Process(XmlNode node, Object parent, Type nodeType) in :line 0
            at NServiceBus.Serializers.XML.XmlMessageSerializer.Deserialize(Stream stream, IList`1 messageTypesToDeserialize) in :line 0
            at NServiceBus.Pipeline.Behaviors.ExtractLogicalMessagesBehavior.Extract(TransportMessage m) in :line 0
            at NServiceBus.Pipeline.Behaviors.ExtractLogicalMessagesBehavior.Invoke(BehaviorContext context, Action next) in :line 0
       InnerException: 

Also if we switch to the Json serializer we get

Could not find type 'NServiceBus.Unicast.Transport.CompletionMessage' in assembly 
'NServiceBus.Core, Version=4.2.0.0, Culture=neutral, PublicKeyToken=9fc386479f8a226c'.

[SimonCropp]

suspect related to this change #893

[johnsimons]

@andreasohlund are we releasing this fix?

[andreasohlund]

Yes, lets do it!

Sent from my iPhone

On 1 maj 2014, at 04:11, John Simons notifications@github.com wrote:

@andreasohlund are we releasing this fix?

—
Reply to this email directly or view it on GitHub.