Incorrect logging when Retries are disabled

[SimonCropp]

When both SLR and FLR are disable the logging is incorrect in two ways

• Incorrectly reports that FLR has failed when no retry was done

2014-05-06 08:34:09.544 +10:00 [Error] Message with '"9320cdcc-6f7a-41c0-a046-a323008d3352"' id has failed FLR and will be moved to the configured error queue.

• Exception is reported as Info and error does not contain exception information

There are two log entries. The first one is an info which actually contains the exception details. The second is an error which does not contain the exception details. This is problematic because if the user is only monitoring warnings and above (a common scenario) they will not be able to see the exception information.

2014-05-06 08:34:09.472 +10:00 [Information] Failed to process message System.Exception: Foo .....
2014-05-06 08:34:09.544 +10:00 [Error] Message with '"9320cdcc-6f7a-41c0-a046-a323008d3352"' id has failed FLR and will be moved to the configured error queue.

Repro here https://github.com/Particular/BugsRepro/tree/master/DisabledRetryRepro

[SzymonPobiega]

Confirmed that the message gets to the error queue so according to @johnsimons this is the expected behaviour. The info message about failing FLR needs to be changed however.

[SzymonPobiega]

Fixed in #2434

[SzymonPobiega]

Fixed via f2152aa