Exception detail in header is lost if handler throws an AggregateException

[SimonCropp]

When a Handler throws an AggregateException.

class Handler : IHandleMessages<Message>
{
    public void Handle(Message message)
    {
        try
        {
            MethodThatThrows();
        }
        catch (Exception exception)
        {
            throw new AggregateException("My Exception", exception);
        }
    }

    void MethodThatThrows()
    {
        throw new Exception("My Inner Exception");
    }
}

TransportReceiver does a GetBaseException

if (ex is AggregateException)
{
       ex = ex.GetBaseException();
}

Which will unwrap the AggregateException converting it to the instance of Exception("My Inner Exception");. And hence Exception("My Inner Exception"); will be passed to IManageMessageFailures instead of the correct AggregateException("My Exception", exception);

Note that we also do the same thing (ex = ex.GetBaseException();) again in FirstLevelRetries so it needs to be fixed in two locations

[SimonCropp]

@andreasohlund here is one to ruin your lunch

[johnsimons]

This is actually a bit more different then just the highlighted code in the description.

So there are 2 sides to this scenario.

1. User throws an AggregateException that contains only one exception (the example above)
2. User throws an AggregateException that contains multiple exceptions

In scenario 1, yes we are unwrapping the AggregateException and displaying the inner exception.
Yes agree, we are in essence losing the user thrown exception, but IMO we are not losing the true meaning of the error (if you understand what I mean).

In scenario 2, an the original AggregateException is the result of calling GetBaseException() (yes I have been caught in this situation and decompiled the code). So we are not losing the original thrown exception.

Scenario 1 could be remedied with a know issue section in the release notes?

[SimonCropp]

we are not losing the true meaning of the error

perhaps but we are loosing the stack trace and the message. I dont think documenting this as a known bug is enough

[johnsimons]

we are loosing the stack trace and the message. I dont think documenting this as a known bug is enough

I'm pretty sure we are not losing the message (AggregateException.ToString is smart enough to figure out if there is only 1 exception will display that exception message), regarding the stacktrace, not sure, have you tested it?

[SimonCropp]

fixed in d414f49