Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API documentation for FeatureStartupTask.OnStop is incorrect #4657

Closed
cremor opened this issue May 3, 2017 · 2 comments · Fixed by #4658
Closed

API documentation for FeatureStartupTask.OnStop is incorrect #4657

cremor opened this issue May 3, 2017 · 2 comments · Fixed by #4658
Assignees
@timbussmann
Labels
Bug
Milestone
6.3.0

Comments

@cremor
Copy link

cremor commented May 3, 2017

The summary documentation on FeatureStartupTask.OnStop is the same as on OnStart: https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.Core/Features/FeatureStartupTask.cs#L18

Also, you might want to update the param documentation since there is no "bus" any more in v6.
@timbussmann timbussmann mentioned this issue May 3, 2017
Merged
@timbussmann timbussmann self-assigned this May 3, 2017
@timbussmann
Copy link
Contributor

Good catch, raised a PR here: #4658

@andreasohlund andreasohlund added this to the 6.3.0 milestone May 3, 2017
@timbussmann
Copy link
Contributor

thanks again for raising this @cremor , the summary will be fixed with the 6.3 release 👍

@andreasohlund andreasohlund changed the title Summary documentation on FeatureStartupTask.OnStop wrong API documentation for FeatureStartupTask.OnStop is incorrect May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timbussmann timbussmann

Labels
Bug
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

Fix FeatureStartupTask documentation Particular/NServiceBus
3 participants
@cremor @andreasohlund @timbussmann