Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect API documentation for TimeToWaitBeforeTriggeringCriticalErrorOnTimeoutOutages #4708

Closed
cremor opened this issue May 15, 2017 · 1 comment · Fixed by #4714
Closed

Incorrect API documentation for TimeToWaitBeforeTriggeringCriticalErrorOnTimeoutOutages #4708

cremor opened this issue May 15, 2017 · 1 comment · Fixed by #4714
Labels
Bug
Milestone
6.3.0

Comments

@cremor
Copy link

cremor commented May 15, 2017

Minor issue: The XML documentation on endpointConfiguration.TimeToWaitBeforeTriggeringCriticalErrorOnTimeoutOutages() says "By default we wait for 2 seconds for the storage to come back." but the actual default value is 2 minutes. This should either be fixed or not mentioned at all (it's already documented at Handling of persistence errors).
@timbussmann timbussmann mentioned this issue May 16, 2017
Merged
@timbussmann
Copy link
Contributor

good catch, thanks for raising this @cremor

@timbussmann timbussmann added this to the 6.3.0 milestone May 17, 2017
@andreasohlund andreasohlund changed the title XML documentation issue on TimeToWaitBeforeTriggeringCriticalErrorOnTimeoutOutages Incorrect API documentation for TimeToWaitBeforeTriggeringCriticalErrorOnTimeoutOutages May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

Remove incorrect default value in method summary Particular/NServiceBus
3 participants
@cremor @andreasohlund @timbussmann