Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saga audit—completed sagas keep growing when the same correlation ID is re-used #3351

Closed
cquirosj opened this issue Jan 11, 2023 · 0 comments · Fixed by #3878
Closed

Saga audit—completed sagas keep growing when the same correlation ID is re-used #3351

cquirosj opened this issue Jan 11, 2023 · 0 comments · Fixed by #3878
Labels
Bug
Milestone
5.0.1

Comments

@cquirosj
Copy link
Contributor

cquirosj commented Jan 11, 2023 •
edited

When using a saga persister that uses the correlationId as the SagaId. ServiceControl Saga history index incorrectly puts all the changes on the same index record.

how to reproduce

  • Download the saga sample
  • Modify the sample so that it re-uses the same OrderId every time
  • Run a couple of sagas and go into RaveDB Studio and see how all the changes for the different instances are shown under the same index record

Another symptom is when the saga shows like this in ServiceInsight, where a completed Saga shows multiple startOrder message (for example) under the same Saga:

image
@cquirosj cquirosj changed the title Audit Saga - completed Sagas keep growing when the same correlation ID is used Saga audit - completed sagas keep growing when the same correlation ID is re-used Jan 11, 2023
@andreasohlund andreasohlund mentioned this issue Sep 21, 2023
Open
@WilliamBZA WilliamBZA mentioned this issue Dec 4, 2023
Merged
@WilliamBZA WilliamBZA added this to the 5.0.1 milestone Dec 6, 2023
@WilliamBZA WilliamBZA modified the milestones: 5.0.1, 4.33.1 Dec 7, 2023
@adamralph adamralph changed the title Saga audit - completed sagas keep growing when the same correlation ID is re-used Saga audit—completed sagas keep growing when the same correlation ID is re-used Dec 7, 2023
@WilliamBZA WilliamBZA modified the milestones: 4.33.1, 5.0.1 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging a pull request may close this issue.

Cap the maximum number of entries in SagaDetailsIndex to 50k Particular/ServiceControl
3 participants
@andreasohlund @cquirosj @WilliamBZA