Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint Explorer using invalid url when retrieving endpoints (SI 1.10.0) #787

Closed
cjoergensen opened this issue Feb 22, 2018 · 13 comments · Fixed by #788
Closed

Endpoint Explorer using invalid url when retrieving endpoints (SI 1.10.0) #787

cjoergensen opened this issue Feb 22, 2018 · 13 comments · Fixed by #788
Assignees
Labels
Milestone

Comments

@cjoergensen
Copy link

cjoergensen commented Feb 22, 2018

In version 1.10.0 the Endpoint Explorer is not populated with data.

The logs shows that an invalid url is used when retrieving the data from SC:

billede

@adamralph adamralph added the Bug label Feb 22, 2018
@adamralph adamralph self-assigned this Feb 22, 2018
@adamralph
Copy link
Member

@cjoergensen thanks for reporting this. We're looking into it and will post an update ASAP. For now I suggest you revert to 1.9.1.

@adamralph
Copy link
Member

@cjoergensen can you please tell me which version of ServiceControl you are using?

@cjoergensen
Copy link
Author

@adamralph we are using 1.45.0

@danielmarbach
Copy link
Contributor

@cjoergensen do you have a proxy or load balancer in place?

I added locally a host entry like

127.0.0.1              mycustomdomain.com

did bind SC to

<configuration>
    <appSettings>
        <add key="ServiceControl/Port" value="33333" />
        <add key="ServiceControl/HostName" value="mycustomdomain.com" />

and connected SI to

http://mycustomdomain.com:33333/api

image

Seems to work fine. Do you have any more details to allow us to repro it?

@cjoergensen
Copy link
Author

@danielmarbach oh yes, we are hosting ServicePulse through IIS and using the reverse proxy IIS feature (https://docs.particular.net/servicepulse/install-servicepulse-in-iis).

The IIS Site is configured to use TLS/SSL using a self signed certificate.

@cjoergensen
Copy link
Author

@danielmarbach do note that it is only the "/api/endpoints" request that looks funky, the following requests looks fine.

@danielmarbach
Copy link
Contributor

@cjoergensen yeah we changed that API for a future version of SC to be able to gracefully switch to a new API that we will provide. I guess this line is the offender and we have to fix this asap.

@adamralph
Copy link
Member

adamralph commented Feb 22, 2018

@cjoergensen we've patched this, but before we release, would you mind trying this build of ServiceInsight to see if it fixes the problem for you? If all is good, this is the exact binary we will be releasing.

Build removed (a problem was identified).

@adamralph
Copy link
Member

@cjoergensen FYI I found a problem in the build attached to my previous comment. I'll attach another build ASAP.

@adamralph
Copy link
Member

@cjoergensen please try this build:

ServiceInsight-1.10.1.exe.zip

@cjoergensen
Copy link
Author

@adamralph it looks good:
billede

:-)

@adamralph
Copy link
Member

Great! Thanks for testing. We'll officially release 1.10.1 later today.

@adamralph
Copy link
Member

1.10.1 is released. Thanks again @cjoergensen! https://twitter.com/adamralph/status/966745512828424192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants