Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Version Regex #238

Closed
jasonmoore2k opened this issue Aug 12, 2014 · 2 comments
Closed

Semantic Version Regex #238

jasonmoore2k opened this issue Aug 12, 2014 · 2 comments
Milestone

Comments

@jasonmoore2k
Copy link

Currently, the Regex matches against this pattern:
@"[vV]?(?(?\d+)(.(?\d+))?(.(?\d+))?)(.(?\d+))?(-(?[^+]))?(+(?.))?"

What are your thoughts on making this configurable? Our current repository has hundred of tags used for other purposes, so I'd like to prevent GitVersion from picking up the wrong tags.

Also, when fetching the list of tags, you trim the 'v' from the name before running it through the parser. Is this necessary, if the regex contains the [vV]?

@JakeGinnivan JakeGinnivan added this to the 1.4.0 milestone Nov 15, 2014
@JakeGinnivan
Copy link
Contributor

This will be closed by #302 which has the tag-prefix option and supports a Regex being specified for the prefix. So you can put (version-|v|V) or whatever you want.

@JakeGinnivan
Copy link
Contributor

The SemanticVersion class will no longer strip the [vV] from the front. By the time the version string gets to that class it should be a clean version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants