Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches with uppercase confuse the version extraction from merge commit #375

Closed
anobleperson opened this issue Feb 23, 2015 · 1 comment

Comments

@anobleperson
Copy link

Branches with uppercase confuse the version extraction from merge commit. If the release branch has upper case prefix, the version number cannot be extracted.

This test passes:
[Test]
public void CanHandleReleaseBranchWithStability()
{
using (var fixture = new EmptyRepositoryFixture(new Config()))
{
fixture.Repository.MakeATaggedCommit("1.0.3");
fixture.Repository.CreateBranch("develop");
fixture.Repository.MakeCommits(5);
fixture.Repository.CreateBranch("release-2.0.0-Final");
fixture.Repository.Checkout("release-2.0.0-Final");

        fixture.AssertFullSemver("2.0.0-beta.1+5");
    }
}

This test fails:
[Test]
public void CanHandleReleaseBranchWithStability()
{
using (var fixture = new EmptyRepositoryFixture(new Config()))
{
fixture.Repository.MakeATaggedCommit("1.0.3");
fixture.Repository.CreateBranch("develop");
fixture.Repository.MakeCommits(5);
fixture.Repository.CreateBranch("Release-2.0.0-Final");
fixture.Repository.Checkout("Release-2.0.0-Final");

        fixture.AssertFullSemver("2.0.0-beta.1+5");
    }
}
anobleperson pushed a commit to anobleperson/GitVersion that referenced this issue Feb 23, 2015
anobleperson pushed a commit to anobleperson/GitVersion that referenced this issue Feb 24, 2015
JakeGinnivan added a commit that referenced this issue Mar 9, 2015
Fixes #375 - Made known merge branch version number extraction case insensitive
@JakeGinnivan
Copy link
Contributor

Fixed in >3.0.0-beta.1 (unreleased)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants