Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect PR version in 3.0 #415

Closed
JakeGinnivan opened this issue Apr 6, 2015 · 3 comments
Closed

Incorrect PR version in 3.0 #415

JakeGinnivan opened this issue Apr 6, 2015 · 3 comments

Comments

@JakeGinnivan
Copy link
Contributor

We have released 3.0.0-beta.1 but not 3.0.0. So pull requests should be versioned 3.0.0-pullrequest.000 rather than 3.0.1-pullrequest.000
@JakeGinnivan
Copy link
Contributor Author

#394 should have fixed.

@GeertvanHorrik
Copy link
Contributor

Not sure if I agree. Will the PR be included in 3.0.0 or 3.0.1? That depends. The question is what should be done with the default (I think next, as soon as you release a beta (release branch), you only want fixes, right)?

@JakeGinnivan JakeGinnivan mentioned this issue May 29, 2015
Closed
@JakeGinnivan
Copy link
Contributor Author

@GeertvanHorrik if the PR is merged before 3.0.0 is released then yes. If 3.0 is released then if the PR gets rebuilt it will be rebuilt as 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeGinnivan @GeertvanHorrik