Fixed libgit2 bug/deprecated #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
In libgit2 the "Credentials" property is deprecated, instead CredentialsHelper should be used. In 0.19 there is a bug with the Credentials property when cloning, using the "correct" way (CredentialsHelper) fixes the bug: libgit2/libgit2sharp#834 In order to be consistent I changed also the fetch method.
yannisgu
force-pushed
the
fixCredentials
branch
from
eaeae26
to
6c7814f
Compare
|
Style is fixed now |
JakeGinnivan
added a commit
that referenced
this pull request
Dec 4, 2014
Fixed libgit2 bug/deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libgit2 the "Credentials" property is deprecated, instead
CredentialsHelper should be used. In 0.19 there is a bug with the
Credentials property when cloning, using the "correct" way
(CredentialsHelper) fixes the bug:
libgit2/libgit2sharp#834
In order to be consistent I changed also the fetch method.
Sorry for the missing tests, but I really don't know how to write a test for this?