Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libgit2sharp #386

Closed
wants to merge 6 commits into from
Closed

Updated libgit2sharp #386

wants to merge 6 commits into from

Conversation

GeertvanHorrik
Copy link
Contributor

Quite a few breaking changes, and I needed to do this anyway because of libgit2/libgit2sharp#993 to check if it is fixed in the latest version.

@JakeGinnivan
Copy link
Contributor

I don't want to take anything into v2.x if at all possible. Lots has changed in the v3 branch and this would likley conflict quite badly. Any chance you could look at applying to the release/3.0.0 branch?

@andreasohlund how is the testing of v3 going? Can we merge it into master yet?

@GeertvanHorrik
Copy link
Contributor Author

I wasn't sure, I didn't want to introduce this into v3 (because I know it's beta / RC). But no problem, I can do that. Just give me the signal if you want to.

@JakeGinnivan
Copy link
Contributor

Basically as far as I am concerned v3 is done. Need people to verify it still works fine for then before releasing it.

I am not going to merge this as looking through the changes it would be merge hell for me when I need to merge v3 into master :P

If you can test v3 as well then that would be super handy, there was so much changed I wanted a few people to verify before releasing stable

@gep13
Copy link
Member

gep13 commented Mar 13, 2015

For what's is worth...

I have been using v3 in the ChocolateyGUI build process for the last few weeks, and it has been working great 👍

@andreasohlund
Copy link
Contributor

I'd say we're good to go

On Fri, Mar 13, 2015 at 10:48 AM, Gary Ewan Park notifications@github.com
wrote:

For what's is worth...

I have been using v3 in the ChocolateyGUI build process for the last few
weeks, and it has been working great [image: 👍]


Reply to this email directly or view it on GitHub
#386 (comment)
.

@JakeGinnivan
Copy link
Contributor

There is a failing test on 3.0.0 branch. Lets fix and merge/release sometime this week/weekend?

@nulltoken
Copy link
Contributor

Would you be willing to go with a pre-release version of LibGit2Sharp, I'd suggest you to move to https://www.nuget.org/packages/LibGit2Sharp/0.22.0-pre20150317225305

There are tons of breaking changes in this one that you may be willing to cope with sooner rather than later. As usual, ping me would you need any help, I'll be happy to give a hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants