[SPIKE] A more strict approach for finding versions in commit messages

[orjan]

It's hard to satisfy the tests without making the assumption that the relevant version is located at the first line. I don't the like the implementation but I think the added tests is correct?

References #385

[orjan]

I have a couple of issues with this implementation.

In order to support:

        [TestCase("Finish Release-0.12.0", true, "0.12.0")] //Support Syntevo SmartGit/Hg's Gitflow merge commit messages for finishing a 'Release' branch
        [TestCase("Finish 0.14.1", true, "0.14.1")] //Support Syntevo SmartGit/Hg's Gitflow merge commit messages for finishing a 'Hotfix' branch

and not library updates in merge commits with an aggregated commit history like:

Merge pull request #1 in FOO/bar from feature/ISSUE-1 to develop
* commit '38560a7eed06e8d3f3f1aaf091befcdf8bf50fea':
  Updated jQuery to v2.1.3

We'll need to make some assumptions:
orjan@db7beab#diff-ff51c8573866921bbeb1edf0998dc6f8R47
"^.*?(-|/|'|Finish )(?<PossibleVersions>\d+\.\d+\.\d+)"

• The version is located at the first commit line
• and starts with ', /, - or Finish

This makes the feature hard to understand for the users, why is my message picked up as a version or why not is it picked up. This makes the implementation error prone and fussy e.g. why if Finish a magical word?

Another option would be to make this feature optional and allow users to specify how to find the version in a commit message via configuration. But that will cause breaking changes.

Thoughts @JakeGinnivan?

[JakeGinnivan]

This is fine, it passes all the tests so I am happy.