Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate temp file directory not existing when cleaning up #408

Conversation

neoeinstein
Copy link
Contributor

This handles an issue that sometimes happens while building on my build server. In this case, IntermediateOutputPath is not set, and so GitVersionTask falls back to the Temp path. On the build server, this folder does not initially contain a "GitVersionTask" folder. Thus, when reaching TempFileTracker.DeleteTempFiles() the process throws a DirectoryNotFoundException.

[19:11:37][Step 1/1]        UpdateAssemblyInfo:
[19:11:37][Step 1/1]          Version not in cache. Calculating version.
[19:11:37][Step 1/1]          Running against branch: hotfix-0.3.5
[19:11:37][Step 1/1]          Base Versions:
[19:11:37][Step 1/1]          Fallback base version: 0.1.0 from commit ******************************6715ab58c3
[19:11:37][Step 1/1]          NextVersion in GitVersionConfig.yaml: 0.3.5 from commit External Source
[19:11:37][Step 1/1]          Git tag '0.3.4': 0.3.4 from commit ******************************bede1c3ae2
[19:11:37][Step 1/1]          Merge message 'Merge branch 'hotfix-0.3.4'': 0.3.4 from commit ******************************bede1c3ae2
[19:11:37][Step 1/1]          Version in branch name: 0.3.5 from commit ******************************88a41db6e6
[19:11:37][Step 1/1]          Base version used: Version in branch name: 0.3.5 from commit ******************************88a41db6e6
[19:11:37][Step 1/1]          Skipping version increment
[19:11:37][Step 1/1]          Applicable build agent found: 'TeamCity'.
[19:11:37][Step 1/1]          Executing GenerateSetVersionMessage for 'TeamCity'.
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[buildNumber '0.3.5-beta.1']
[19:11:37][Step 1/1]          Executing GenerateBuildLogOutput for 'TeamCity'.
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.Major' value='0']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.Major' value='0']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.Minor' value='3']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.Minor' value='3']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.Patch' value='5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.Patch' value='5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.PreReleaseTag' value='beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.PreReleaseTag' value='beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.PreReleaseTagWithDash' value='-beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.PreReleaseTagWithDash' value='-beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.BuildMetaData' value='1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.BuildMetaData' value='1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.FullBuildMetaData' value='1.Branch.hotfix-0.3.5.Sha.******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.FullBuildMetaData' value='1.Branch.hotfix-0.3.5.Sha.******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.MajorMinorPatch' value='0.3.5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.MajorMinorPatch' value='0.3.5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.SemVer' value='0.3.5-beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.SemVer' value='0.3.5-beta.1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.LegacySemVer' value='0.3.5-beta1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.LegacySemVer' value='0.3.5-beta1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.LegacySemVerPadded' value='0.3.5-beta0001']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.LegacySemVerPadded' value='0.3.5-beta0001']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.AssemblySemVer' value='0.3.0.0']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.AssemblySemVer' value='0.3.0.0']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.FullSemVer' value='0.3.5-beta.1+1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.FullSemVer' value='0.3.5-beta.1+1']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.InformationalVersion' value='0.3.5-beta.1+1.Branch.hotfix-0.3.5.Sha.******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.InformationalVersion' value='0.3.5-beta.1+1.Branch.hotfix-0.3.5.Sha.******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.BranchName' value='hotfix-0.3.5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.BranchName' value='hotfix-0.3.5']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.Sha' value='******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.Sha' value='******************************affad7254c']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.NuGetVersionV2' value='0.3.5-beta0001']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.NuGetVersionV2' value='0.3.5-beta0001']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='GitVersion.NuGetVersion' value='0.3.5-beta0001']
[19:11:37][Step 1/1]          
[19:11:37][Step 1/1] ##teamcity[setParameter name='system.GitVersion.NuGetVersion' value='0.3.5-beta0001']
[19:11:37][Step 1/1]      4>MSBUILD : error : Error occurred: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\TeamCity\BuildAgent\temp\buildTmp\GitVersionTask'. [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at System.IO.FileSystemEnumerableIterator`1.CommonInit() [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost) [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at System.IO.Directory.GetFiles(String path) [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at TempFileTracker.DeleteTempFiles() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\TempFileTracker.cs:line 16 [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at GitVersionTask.UpdateAssemblyInfo.InnerExecute() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\AssemblyInfoBuilder\UpdateAssemblyInfo.cs:line 65 [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] MSBUILD : error :    at GitVersionTask.UpdateAssemblyInfo.Execute() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\AssemblyInfoBuilder\UpdateAssemblyInfo.cs:line 44 [C:\TeamCity\BuildAgent\work\7b27b747153ac0b7\src\***\***.csproj]
[19:11:37][Step 1/1] ##teamcity[buildStatus status='FAILURE' text=': (0,0): Error occurred: System.IO.DirectoryNotFoundException: Could not find a part of the path |'C:\TeamCity\BuildAgent\temp\buildTmp\GitVersionTask|'.   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)   at System.IO.FileSystemEnumerableIterator`1.CommonInit()   at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)   at System.IO.Directory.GetFiles(String path)   at TempFileTracker.DeleteTempFiles() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\TempFileTracker.cs:line 16   at GitVersionTask.UpdateAssemblyInfo.InnerExecute() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\AssemblyInfoBuilder\UpdateAssemblyInfo.cs:line 65   at GitVersionTask.UpdateAssemblyInfo.Execute() in c:\BuildAgent\work\5106452ed7682238\GitVersionTask\AssemblyInfoBuilder\UpdateAssemblyInfo.cs:line 44']

JakeGinnivan added a commit that referenced this pull request Mar 25, 2015
…eleted-when-trying-to-delete

Tolerate temp file directory not existing when cleaning up
@JakeGinnivan JakeGinnivan merged commit 5415748 into GitTools:master Mar 25, 2015
@JakeGinnivan
Copy link
Contributor

Thanks!

@neoeinstein neoeinstein deleted the tolerate-temp-file-already-deleted-when-trying-to-delete branch March 25, 2015 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants