Added support for -nofetch command line argument and 'NoFetch' MSBuild T... #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Task parameter, to suppress fetching from remotes during execution.
| { | ||
| if (string.IsNullOrEmpty(gitDirectory)) | ||
| { | ||
| throw new WarningException("Failed to find .git directory on agent."); | ||
| } | ||
|
|
||
| GitHelper.NormalizeGitDirectory(gitDirectory, authentication); | ||
| if (!noFetch) |
There was a problem hiding this comment.
To save this duplication can we pass it down to NormalizeGitDirectory, otherwise it will be easy to forget this step with new Build Servers
added 2 commits
March 31, 2015 15:42
1. Passed down noFetch param to NormalizeGitDirectory method. 2. Updated ArgumentParser to ensure that individual switches such as -nofetch do not interfere with existing functionality. ArgumentParser should also now support switches with multiple values such as '-myswitch value1 value2' if the validation checks are removed.
…parsed as names not values.
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ask parameter, to suppress fetching from remotes during execution.
Up for review and discussion. I had no problem feeding in the noFetch argument, but I couldn't find an obvious way to test whether or not GitVersion was trying to fetch from a remote or not given the current test fixtures available. Any pointers?