Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move map layers and navigation functionality into separate module / Перeнести карту (слои и навигация) в отдельный модуль #279

Open
kabalin opened this issue Nov 17, 2020 · 5 comments
Labels
CI/CD Continued Integration / Continued Development Map all issues about map (display, selecting, clustering, receiving etc.) Priority: Major

Comments

@kabalin
Copy link
Member

kabalin commented Nov 17, 2020

public/js/module/map/map.js is getting difficult to maintain in light of upcoming changes. I propose to move functionality realted to map initialisation (map instance, layers, navigation tools) to the separate AMD module.

This will allow immediately:

This change will also make easier to address:
#199, #212, #263, #358

@kabalin kabalin changed the title Refactor client map: move layers and navigation functionality into separate module / Перeнести пользовательский функционал карты (слои и навигация) в отдельный модуль Move map layers and navigation functionality into separate module / Перeнести карту (слои и навигация) в отдельный модуль Nov 17, 2020
@kabalin
Copy link
Member Author

kabalin commented Nov 18, 2020

Возьмусь сделать 😃

@kabalin
Copy link
Member Author

kabalin commented Jan 5, 2022

When working on this, consider using "over-zoom" rather than automatic map switching on reaching max zoom level for the map. This will simplify working with areas containing high density of points.

@mkgrgis
Copy link
Contributor

mkgrgis commented Jan 5, 2022

Maximal level of overzoom in JOSM/leaflet.js practice usually is 21. There is real sources of tiles with this maxZoom (not in PastVu list).

@mkgrgis
Copy link
Contributor

mkgrgis commented Feb 19, 2022

@kabalin , can You post here a task list for creating separate map module? How can I help?

@kabalin
Copy link
Member Author

kabalin commented Aug 2, 2022

Пока отписываю себя от этой задачи, вдруг кто-то возьмется пока я до нее доберусь.

Тут еще нужно подумать как сделать лучше. Изначально идея была перенести слои и навигацию (зум, смещение, выбор карты) в отдельный модуль, но теперь я склоняюсь что новый модуль нужно назвать layers и хранить в нем только функционал связанный со слоями.

@kabalin kabalin removed their assignment Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continued Integration / Continued Development Map all issues about map (display, selecting, clustering, receiving etc.) Priority: Major
Development

No branches or pull requests

3 participants