Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding] - Permissions Flow Bugs #930

Open
Patrick-Erichsen opened this issue May 29, 2020 · 5 comments
Open

[Onboarding] - Permissions Flow Bugs #930

Patrick-Erichsen opened this issue May 29, 2020 · 5 comments
Assignees
Labels
good first issue Good for newcomers UI/UX UI or UX related

Comments

@Patrick-Erichsen
Copy link
Contributor

Issue type

UI

Steps to reproduce

  • Navigate to permissions steps in onboarding
  • Select "Enable Location"
  • Screen advances immediately without waiting for the user to approve/deny location permissions

Expected Behavior

  • When I click "Enable Location", the screen does not advance until I approve or deny

Upload any files to the Issue useful in helping us to investigate

In the screenshot below, note that the screen has advanced to the HA permissions before the user has selected approve/deny from location permissions
Screen Shot 2020-05-28 at 11 18 46 PM

@Patrick-Erichsen Patrick-Erichsen added UI/UX UI or UX related good first issue Good for newcomers labels May 29, 2020
@Patrick-Erichsen
Copy link
Contributor Author

Patrick-Erichsen commented May 29, 2020

@Namit-Agrawal want to take a look at this?

Part of the issue I believe is related to this typo.

- Platform.OS === 'andriod'
+ Platform.OS === 'android'

@Namit-Agrawal
Copy link
Contributor

Sure, I can work on this!

@rsrinivasan1
Copy link

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

@summetj
Copy link
Collaborator

summetj commented Jul 18, 2020

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

Hi Rsrinivasan1 - Do you have access to our Slack? If not, fill out the "Join-Us" form on the PathCheck.org website (directly: bit.ly/pathcheck) and I'll invite you to Slack and send you a welcome email. Then we can assist you in the #app_dev slack channel.

@rsrinivasan1
Copy link

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

Hi Rsrinivasan1 - Do you have access to our Slack? If not, fill out the "Join-Us" form on the PathCheck.org website (directly: bit.ly/pathcheck) and I'll invite you to Slack and send you a welcome email. Then we can assist you in the #app_dev slack channel.

I just submitted the form, thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI/UX UI or UX related
Projects
None yet
Development

No branches or pull requests

4 participants