Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proteins: NCBI linkouts #798

Closed
2 tasks
jvwong opened this issue Aug 11, 2020 · 2 comments
Closed
2 tasks

Support for proteins: NCBI linkouts #798

jvwong opened this issue Aug 11, 2020 · 2 comments
Assignees
Labels

Comments

@jvwong
Copy link
Member

jvwong commented Aug 11, 2020

With the introduction of Sars-Cov-2 proteins (PathwayCommons/grounding-search#72) it is no longer safe to assume that the grounding id for namespace:ncbi originates from the GENE database. Thankfully, there is information provided (type) to make this decision.

  • Editor, entity tooltip

image

  • Explore view, entity info

image

Other ...?

@jvwong
Copy link
Member Author

jvwong commented Aug 11, 2020

Also check that the exports (BioPAX, SBGN, txt) make sense.

@jvwong jvwong added the bug label Aug 11, 2020
@jvwong jvwong self-assigned this Aug 11, 2020
@jvwong
Copy link
Member Author

jvwong commented Aug 12, 2020

What this issue boils down to is we need to start using standardized/consistent MIRIAM-based names for data across these projects (i.e. grounding-search, factoid). The added benefit is they resolve through identifers.org via provider de jour.

So the coupled requirements are:

  • Update grounding-search to use registered namespace for each collection
  • Update factoid with compensatory changes

Depends on PathwayCommons/grounding-search#75

Notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant