Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetpackCompose] Add support to share note as Image #119

Closed
PatilShreyas opened this issue Feb 7, 2021 · 8 comments · Fixed by #275
Closed

[JetpackCompose] Add support to share note as Image #119

PatilShreyas opened this issue Feb 7, 2021 · 8 comments · Fixed by #275
Labels
hacktoberfest For partifipating in Hacktoberfest help wanted Extra attention is needed noty-android priority-medium
Projects
NotyKT
Milestone
v1.3.0

Comments

@PatilShreyas
Copy link
Owner

In the notes details screen, share as Image option should be provided.

Question:
How to convert Composables into Bitmap?
@PatilShreyas PatilShreyas added this to To do in NotyKT via automation Feb 7, 2021
@PatilShreyas PatilShreyas added this to the v1.0.1 milestone Feb 7, 2021
@PatilShreyas PatilShreyas modified the milestones: v1.1.0, v1.2.0 Aug 6, 2021
@PatilShreyas PatilShreyas removed this from the v1.2.0 milestone Aug 29, 2021
@ch8n
Copy link
Contributor

ch8n commented Oct 11, 2021

Hi @PatilShreyas is this up for grab for Hacktoberfest ?

@PatilShreyas
Copy link
Owner Author

Yes @ch8n

@PatilShreyas PatilShreyas added the hacktoberfest For partifipating in Hacktoberfest label Oct 11, 2021
@PatilShreyas
Copy link
Owner Author

If you're interested in implementing this, feel free to raise a PR against master branch

@ch8n
Copy link
Contributor

ch8n commented Oct 12, 2021

@PatilShreyas Thanks.
I'm not sure but Composable can’t be converted to Bitmap. I will be creating a View and use setContent to the composable, then I write that to bitmap.

will this be fine?

@PatilShreyas
Copy link
Owner Author

Yes @ch8n. We can convert composable to view by getting LocalView but it captures everything from app bar to bottom of the screen. So it's not good. But yeah, wrapping it in View works since it gives us control.

@ch8n ch8n mentioned this issue Oct 16, 2021
Merged
5 tasks
@ch8n
Copy link
Contributor

ch8n commented Oct 16, 2021

hi @PatilShreyas can you code review I have submitted a PR #269
also have an article that explains its implementation
https://chetan-garg36.medium.com/jetpack-composable-to-bitmap-image-4ddea2fe3238

@PatilShreyas
Copy link
Owner Author

PatilShreyas commented Oct 16, 2021 •
edited
Loading

Yes @ch8n thanks for raising a PR. Have merged it and will be targetting for release in v1.3.0

@PatilShreyas PatilShreyas added this to the v1.2.1 milestone Oct 16, 2021
@PatilShreyas PatilShreyas mentioned this issue Oct 24, 2021
Merged
5 tasks
@PatilShreyas PatilShreyas linked a pull request Oct 24, 2021 that will close this issue
[Feature - ComposeApp] Share note as Image #275
Merged
5 tasks
@PatilShreyas
Copy link
Owner Author

Implemented and Released in v1.3.0. Thank you @ch8n for the contribution 😃

NotyKT automation moved this from To do to Done Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest For partifipating in Hacktoberfest help wanted Extra attention is needed noty-android priority-medium
Projects
NotyKT
Status: Done
NotyKT
Done
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

[Feature - ComposeApp] Share note as Image PatilShreyas/NotyKT
2 participants
@ch8n @PatilShreyas