Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ComposeApp] Improve UI for dark mode #295

Merged
merged 3 commits into from Oct 30, 2021
Merged

[ComposeApp] Improve UI for dark mode #295

merged 3 commits into from Oct 30, 2021

Conversation

yogeshpaliyal
Copy link
Contributor

@yogeshpaliyal yogeshpaliyal commented Oct 29, 2021 •
edited

Summary

  1. Dark mode improvements in Login and Signup
  2. Fix Clipping of Card Shadow in About page

Description for the changelog

A picture or screenshot regarding change

image

image

image

Checklist

  • Build and linting is passing.
  • This change is not breaking existing flow of a system.
  • I have written test case for this change. (not required)
  • This change is tested from all aspects.
  • Implemented any new third-party library (Which not existed before this change).

closes #282 , closes #286

@yogeshpaliyal yogeshpaliyal marked this pull request as draft October 29, 2021 15:34
@yogeshpaliyal yogeshpaliyal marked this pull request as ready for review October 29, 2021 15:34
@yogeshpaliyal
Copy link
Contributor Author

@PatilShreyas can you have a look?

@PatilShreyas PatilShreyas changed the base branch from master to v1.3.1-dev October 30, 2021 10:18
PatilShreyas
PatilShreyas approved these changes Oct 30, 2021
View reviewed changes
Copy link
Owner

@PatilShreyas PatilShreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @yogeshpaliyal, LGTM 😃. Merging it... 🚀

@PatilShreyas
Copy link
Owner

Waiting for CI to run successful

@PatilShreyas PatilShreyas changed the title Improve/dark mode [ComposeApp] Improve UI for dark mode Oct 30, 2021
@PatilShreyas
Copy link
Owner

If you are doing this for hacktoberfest, then adding a label as well.

@PatilShreyas PatilShreyas merged commit 9c35e1a into PatilShreyas:v1.3.1-dev Oct 30, 2021
@yogeshpaliyal
Copy link
Contributor Author

Not just for hacktoberfest, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatilShreyas PatilShreyas PatilShreyas approved these changes

Assignees
No one assigned
Labels
hacktoberfest For partifipating in Hacktoberfest hacktoberfest-accepted noty-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark mode Improvements About page - Shadow cutting of visit card
2 participants
@yogeshpaliyal @PatilShreyas