Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composables reports table is missing some non-skippable composables #9

Closed
AndreasBoehm opened this issue Sep 5, 2022 · 2 comments · Fixed by #18
Closed

Composables reports table is missing some non-skippable composables #9

AndreasBoehm opened this issue Sep 5, 2022 · 2 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@AndreasBoehm
Copy link

It looks like some composables can't be parsed from the composables.tx file.

Example with a lambda that has parameters.

restartable scheme("[androidx.compose.ui.UiComposable]") fun MyComposable(
  unstable periods: List<DataClass>
  stable selectedPeriod: DataClass
  stable onPeriodSelected: Function2<@[ParameterName(name = 'myList')] List<DataClass>, @[ParameterName(name = 'mySingleItem')] DataClass, Unit>
  stable onCloseClicked: Function0<Unit>
)

Example with missing stability information

restartable scheme("[androidx.compose.ui.UiComposable]") fun ComposableTwo(
  stable modifier: Modifier? = @static Companion
  data: SomeDataClass
)

Would be awesome if you could take a look at this.

Thanks,
Andi

@PatilShreyas
Copy link
Owner

Thanks for raising this! Will take a look.

@PatilShreyas PatilShreyas added the bug Something isn't working label Jan 22, 2023
@PatilShreyas PatilShreyas linked a pull request Jan 24, 2023 that will close this issue
@PatilShreyas
Copy link
Owner

This has been fixed and released in v1.0.0-alpha03. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants