Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew support #15

Open
nikolaykasyanov opened this issue Jul 2, 2018 · 4 comments
Open

Homebrew support #15

nikolaykasyanov opened this issue Jul 2, 2018 · 4 comments

Comments

@nikolaykasyanov
Copy link

It'd be great to be able to deploy the app on CI servers automatically, for example using brew.

@nikolaykasyanov
Copy link
Author

nikolaykasyanov commented Jul 3, 2018

A have a formula prototype, it uses our fork though:

class ScreenshotframerCli < Formula
  desc "With Screenshot Framer you can easily create nice-looking and localized App Store Images."
  homepage "https://github.com/IdeasOnCanvas/ScreenshotFramer"
  url "https://github.com/flix-tech/ScreenshotFramer.git",
    :branch => "flixtech",
    :revision => "7251745847a41e276c99c73716d0c41c8854dcf0"
  version "1.0"
  revision 1

  depends_on :xcode => ["9.0", :build]

  def install
    system "ln -sf /usr/bin/true ./.tools/SwiftLint/swiftlint" # SwiftLint is not working properly when run inside brew install, not sure why
    xcodebuild "-project", "Screenshot Framer.xcodeproj",
               "-scheme", "Screenshot-Framer-CLI",
               "DSTROOT=build/install",
               "SYMROOT=build",
               "INSTALL_PATH=/bin",
               "install"
    bin.install "build/install/bin/Screenshot-Framer-CLI"
  end

  test do
    system "#{bin}/Screenshot-Framer-CLI"
  end
end

@Patrick-Kladek
Copy link
Owner

That seems like a good idea. Unfortunately I have no experience with creating a homebrew setup. Do I only have to change the url "https://github.com/flix-tech/ScreenshotFramer.git" with ours or is there more to do?

@nikolaykasyanov
Copy link
Author

@Patrick-Kladek sounds about right, I'd also use a tag instead of the branch & revision combo.

@nikolaykasyanov
Copy link
Author

There may also be a nicer way to disable SwiftLint.

@Patrick-Kladek Patrick-Kladek mentioned this issue Apr 24, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants