Merging $_GET and $_POST

[HassanAlthaf]

https://github.com/PatrickLouys/http/blob/master/src/HttpRequest.php#L19

As you may as well know, you merged the $_GET and $_POST. I think you shouldn't merge them. Why? Imagine this scenario:

Lets say you have a $_GET parameter of key "foo", and at the same time, you submit a form with POST with the same key "foo", and once you merge them, don't you think either one of them will be lost? Therefore, I'd recommend you to split them.

Credits: @samayo for finding out and submitting this argument. I posted this on behalf of him because he is busy.

[PatrickLouys]

I am aware of that. It was a design choice made on purpose at the time. Mixing GET and POST is not a good idea anyway, especially with the same parameter name. In the end it's just a bunch of parameters that you send to the application.

I'll close this for now. If you have other arguments for a split of the parameters let me know :)