New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static analysis issues #10
Comments
Good diagnostics :-) If you're going to be running these during integration, it would helpful to document for plugin developers how we can do the same, with the same configuration ( e.g. CodeQL db). Otherwise, I can't verify that any code changes I made actually pass the analysis and we'll just have to iterate in issues which is a burden on you. Best if this is integrated into the Rack SDK. |
It won't be integrated in the Rack SDK. It could be integrated in the VCV Rack Plugin Toolchain at some point, but for now I will run it manually during integration. CodeQL is the standard out-of-the-box configuration for for cppcheck is invoked like this:
|
Thanks a lot for the info - helpful! Fixed: 7497e83 |
We are now running static analysis tools CodeQL and cppcheck during the integration process and the following issues were found:
Please take look and see if these need to be adressed.
The text was updated successfully, but these errors were encountered: