You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
If a non-simple version requirement is used and there exists a version of the package newer enough to be outside of the requirement range, the version check reports a new version. That version is therefore displayed and cargo install is still called on it and it results in a no-op.
Expected behavior
Only versions inside the requirement range should be considered and the call should not be made if there is no new version inside it.
To Reproduce
Steps to reproduce the behavior:
Have a config file with the following:
[packages]
pastel = "=0.8.0"
Run cargo liner ship and let it finish the install.
Run it again.
See output below.
Output
INFO cargo_liner::cargo > Fetching latest package versions...
INFO cargo_liner > Results:
INFO cargo_liner > cargo-liner ✔
INFO cargo_liner > pastel 0.8.0 -> 0.9.0
INFO cargo_liner::cargo > Updating `pastel`...
Ignored package `pastel v0.8.0` is already installed, use --force to override
INFO cargo_liner > Done.
Additional information
Fixing this won't be easy: it would need to rework the method used, most probably to move away from cargo search and to use requests to the registry API.
I think the easiest would be to simply wait for https://github.com/hi-rustin/cargo-information to be merged directly in Cargo. It already does things intelligently, more so than I would be ready to do at least, and it being merged would mean no optional dependency trouble.
Description
If a non-simple version requirement is used and there exists a version of the package newer enough to be outside of the requirement range, the version check reports a new version. That version is therefore displayed and
cargo install
is still called on it and it results in a no-op.Expected behavior
Only versions inside the requirement range should be considered and the call should not be made if there is no new version inside it.
To Reproduce
Steps to reproduce the behavior:
cargo liner ship
and let it finish the install.Output
Additional information
Fixing this won't be easy: it would need to rework the method used, most probably to move away from
cargo search
and to use requests to the registry API.Spawned from #6.
The text was updated successfully, but these errors were encountered: