Trigger a 'collision' event when there's an collision by ids. #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to open a discussion whether there's really a bug here, and if so, how to fix it.
This patch is what I'm currently using to resolve the issue, but it might not be a good general solution.
The problem:
BBR claims to rely on keeping only a single instance of each model in it's own storage collections. However, in at least one case, it would silently replace a model with a newer copy. This causes problems since the orphaned "old" copy can still be alive in other collections. BBR will now at least trigger a 'collision' event when this happens, which allows users to handle the collision intelligently, e.g. by destroying the old copy.
This collision can arise from the following sequence:
Should this be allowed to happen? Doesn't this violate some fundamental assumptions made by BBR? What should happen in this case? This patch takes the approach that only the model itself will know how to appropriately resolve the conflict.
Let me know if you'd like more detail.